From: Ben Walton <bwalton@artsci.utoronto.ca>
Date: Mon, 06 Aug 2012 22:39:55 GMT
Subject: Re: [PATCH] Avoid crippled getpass function on Solaris
Message-ID: <1344292395-sup-1921@pinkfloyd.chass.utoronto.ca>
In-Reply-To: <20120806223113.GA16298@sigill.intra.peff.net>

Excerpts from Jeff King's message of Mon Aug 06 18:31:13 -0400 2012:

> Looking over the code, I recall now why I used stdio: strbuf_getline
> requires it. These days we have strbuf_getwholeline_fd. It's
> slightly less efficient (it has to read() a character at a time),
> but since we are talking about a few characters of keyboard input,
> it should be OK.

I noticed the same requirement.  I'm currently building/testing a
patch that switches from FILE -> fd and also to
strbuf_getwholeline_fd.  Personally, I like this approach more than
calling an open function multiple times.

Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302