From: Matthieu Moy Date: Wed, 27 Jun 2012 09:10:17 GMT Subject: [PATCH 2/5] git-remote-mediawiki: don't "use encoding 'utf8';" Message-ID: <1340788220-10084-3-git-send-email-Matthieu.Moy@imag.fr> In-Reply-To: <1340788220-10084-1-git-send-email-Matthieu.Moy@imag.fr> The use of this statement is generally discouraged, and is too intrusive for us: it forces the HTTP requests made by the API to contain only valid UTF-8 characters. This would break the upload of binary files. Signed-off-by: Matthieu Moy --- contrib/mw-to-git/git-remote-mediawiki | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/contrib/mw-to-git/git-remote-mediawiki b/contrib/mw-to-git/git-remote-mediawiki index 781dfe2..f2e841e 100755 --- a/contrib/mw-to-git/git-remote-mediawiki +++ b/contrib/mw-to-git/git-remote-mediawiki @@ -36,11 +36,10 @@ use strict; use MediaWiki::API; use DateTime::Format::ISO8601; -use encoding 'utf8'; -# use encoding 'utf8' doesn't change STDERROR -# but we're going to output UTF-8 filenames to STDERR +# By default, use UTF-8 to communicate with Git and the user binmode STDERR, ":utf8"; +binmode STDOUT, ":utf8"; use URI::Escape; use IPC::Open2; -- 1.7.11.5.g0c7e058.dirty