From: Nguyễn Thái Ngọc Duy Date: Thu, 19 Apr 2012 14:05:29 GMT Subject: [PATCH nd/threaded-index-pack] index-pack: disable threading if NO_PREAD is defined Message-ID: <1334844329-24557-1-git-send-email-pclouds@gmail.com> NO_PREAD simulates pread() as a sequence of seek, read, seek in compat/pread.c. The simulation is not thread-safe because another thread could move the file offset away in the middle of pread operation. Do not allow threading in that case. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/index-pack.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/builtin/index-pack.c b/builtin/index-pack.c index 847dbb3..c1c3c81 100644 --- a/builtin/index-pack.c +++ b/builtin/index-pack.c @@ -39,6 +39,11 @@ struct base_data { int ofs_first, ofs_last; }; +#if !defined(NO_PTHREADS) && defined(NO_PREAD) +/* NO_PREAD uses compat/pread.c, which is not thread-safe. Disable threading. */ +#define NO_PTHREADS +#endif + struct thread_local { #ifndef NO_PTHREADS pthread_t thread; -- 1.7.8.36.g69ee2