From: Neil Horman Date: Thu, 05 Apr 2012 19:39:04 GMT Subject: [PATCH 4/5] git-cherry-pick: Add test to validate new options [v2] Message-ID: <1333654745-7898-5-git-send-email-nhorman@tuxdriver.com> In-Reply-To: <1333654745-7898-1-git-send-email-nhorman@tuxdriver.com> Since we've added the --allow-empty and --ignore-if-made-empty options to git cherry-pick we should also add a test to ensure that its working properly Signed-off-by: Neil Horman CC: Jeff King CC: Phil Hord CC: Junio C Hamano --- t/t3505-cherry-pick-empty.sh | 31 ++++++++++++++++++++++++++++++- 1 files changed, 30 insertions(+), 1 deletions(-) diff --git a/t/t3505-cherry-pick-empty.sh b/t/t3505-cherry-pick-empty.sh index c10b28c..049ed28 100755 --- a/t/t3505-cherry-pick-empty.sh +++ b/t/t3505-cherry-pick-empty.sh @@ -18,7 +18,12 @@ test_expect_success setup ' echo third >> file1 && git add file1 && test_tick && - git commit --allow-empty-message -m "" + git commit --allow-empty-message -m "" && + + git checkout master && + git checkout -b empty-branch2 && + test_tick && + git commit --allow-empty -m "empty" ' @@ -48,4 +53,28 @@ test_expect_success 'index lockfile was removed' ' ' +test_expect_success 'cherry pick an empty non-ff commit without --allow-empty' ' + git checkout master && + echo fouth >> file2 && + git add file2 && + git commit -m "fourth" && { + git cherry-pick empty-branch2 + test "$?" = 1 + } +' + +test_expect_success 'cherry pick an empty non-ff commit with --allow-empty' ' + git checkout master && { + git cherry-pick --allow-empty empty-branch2 + test "$?" = 0 + } +' + +test_expect_success 'cherry pick with --ignore-if-made-empty' ' + git checkout master && { + git cherry-pick --allow-empty --ignore-if-made-empty empty-branch2 + test "$?" = 0 + } +' + test_done -- 1.7.7.6