From: Ramkumar Ramachandra Date: Fri, 09 Dec 2011 15:41:58 GMT Subject: [PATCH 1/9] revert: free msg in format_todo() Message-ID: <1323445326-24637-2-git-send-email-artagnon@gmail.com> In-Reply-To: <1323445326-24637-1-git-send-email-artagnon@gmail.com> Memory allocated to the fields of msg by get_message() isn't freed. This is potentially a big leak, because fresh memory is allocated to store the commit message for each commit. Fix this using free_message(). Reported-by: Jonathan Nieder Signed-off-by: Ramkumar Ramachandra Signed-off-by: Junio C Hamano --- builtin/revert.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/builtin/revert.c b/builtin/revert.c index 1ea525c..0c6d3d8 100644 --- a/builtin/revert.c +++ b/builtin/revert.c @@ -706,6 +706,7 @@ static int format_todo(struct strbuf *buf, struct commit_list *todo_list, if (get_message(cur->item, &msg)) return error(_("Cannot get commit message for %s"), sha1_abbrev); strbuf_addf(buf, "%s %s %s\n", action_str, sha1_abbrev, msg.subject); + free_message(&msg); } return 0; } -- 1.7.7.3