From: Joe Perches <joe@perches.com>
Date: Thu, 08 Dec 2011 20:51:26 GMT
Subject: Re: [PATCH] git-send-email: Add auto-cc to all body signatures
Message-ID: <1323377486.1762.71.camel@joe2Laptop>
In-Reply-To: <7v8vmmj1ng.fsf@alter.siamese.dyndns.org>

On Thu, 2011-12-08 at 11:37 -0800, Junio C Hamano wrote:
> Joe Perches <joe@perches.com> writes:
> > Many types of signatures are used by various projects.
> > The most common type is formatted:
> > 	"[some_signature_type]-by: First Last <email@domain.tld>"
> > e.g:
> > 	"Reported-by: First Last <email@domain.tld>" (no quotes are used)
> This is just a phrasing issue, but I am a bit reluctant about the name
> "signature".

I've called all these markings signatures.
Maybe email-address-tags or another name could be used.
I'm not bothered one way or another by any chosen name.

> Does your change do the right thing on such an address-less entry?  The
> answer to this question must start with the definition of "the right thing
> to do is X", of course.

All addresses go through "extract_valid_address".
Invalid addresses are not used.