From: Artem Bityutskiy Date: Sun, 04 Dec 2011 13:30:16 GMT Subject: Re: [PATCH 2/2] builtin/apply.c: report error on failure to recognize input Message-ID: <1323005418.9400.49.camel@sauron.fi.intel.com> In-Reply-To: <1322944550-27344-2-git-send-email-drafnel@gmail.com> On Sat, 2011-12-03 at 14:35 -0600, Brandon Casey wrote: > When git apply is passed something that is not a patch, it does not produce > an error message or exit with a non-zero status if it was not actually > "applying" the patch i.e. --check or --numstat etc were supplied on the > command line. > > Fix this by producing an error when apply fails to find any hunks whatsoever > while parsing the patch. > > This will cause some of the output formats (--numstat, --diffstat, etc) to > produce an error when they formerly would have reported zero changes and > exited successfully. That seems like the correct behavior though. Failure > to recognize the input as a patch should be an error. > > Plus, add a test. > > Reported-by: Artem Bityutskiy > Signed-off-by: Brandon Casey Brandon, Thanks a lot for picking this. I did not reply because I did not have time to look at this after your review yet, it was in my TODO list. But I am happy you picked this and fixed the issue. Tested-by: Artem Bityutskiy -- Best Regards, Artem Bityutskiy