From: Marc-André Lureau Date: Wed, 16 Nov 2011 23:51:13 GMT Subject: [PATCH] mailmap: xcalloc mailmap_info Message-ID: <1321487473-29194-1-git-send-email-marcandre.lureau@gmail.com> This is to avoid reaching free of uninitialized members. With an invalid .mailmap (and perhaps in other cases), it can reach free(mi->name) with garbage for example. --- mailmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mailmap.c b/mailmap.c index 02fcfde..fbf7764 100644 --- a/mailmap.c +++ b/mailmap.c @@ -88,7 +88,7 @@ static void add_mapping(struct string_list *map, me->email = xstrdup(new_email); } } else { - struct mailmap_info *mi = xmalloc(sizeof(struct mailmap_info)); + struct mailmap_info *mi = xcalloc(1, sizeof(struct mailmap_info)); debug_mm("mailmap: adding (complex) entry for %s at index %d\n", old_email, index); if (new_name) mi->name = xstrdup(new_name); -- 1.7.7