From: Wang Hui Date: Mon, 19 Sep 2011 09:51:12 GMT Subject: [PATCH] abspath: increase array size of cwd variable to PATH_MAX Message-ID: <1316425872-30457-1-git-send-email-Hui.Wang@windriver.com> From: Hui Wang If the name length of working dir exceeds 1024 characters, neither git clone nor git init can succeed under the working dir. E.G. %>for ((i=1;i<300;i++));do mkdir 1234567890;cd 1234567890;done %>git clone ~/git fatal: Could not get current working directory: Numerical result out of range This is because both git clone and git init will call abspath.c:real_path(), in the real_path(), it will call getcwd() to get and save current working dir, here we passed a 1024 char size array to the parameter, if the name length of current working dir exceeds 1024, this function will fail. The purpose of calling getcwd() is to save current working dir, then before the real_path() return, restore to the saved dir. We should use PATH_MAX instead of 1024 for the array size. Signed-off-by: Hui Wang --- abspath.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/abspath.c b/abspath.c index f04ac18..2ce1db9 100644 --- a/abspath.c +++ b/abspath.c @@ -24,7 +24,7 @@ int is_directory(const char *path) const char *real_path(const char *path) { static char bufs[2][PATH_MAX + 1], *buf = bufs[0], *next_buf = bufs[1]; - char cwd[1024] = ""; + char cwd[PATH_MAX] = ""; int buf_index = 1; int depth = MAXDEPTH; -- 1.6.3.1