From: Michael Haggerty Date: Thu, 15 Sep 2011 21:10:31 GMT Subject: [PATCH v3 10/22] resolve_ref(): explicitly fail if a symlink is not readable Message-ID: <1316121043-29367-11-git-send-email-mhagger@alum.mit.edu> In-Reply-To: <1316121043-29367-1-git-send-email-mhagger@alum.mit.edu> Previously the failure came later, after a few steps in which the length was treated like the actual length of a string. Even though the old code gave the same answers, it was somewhat misleading. Signed-off-by: Michael Haggerty --- refs.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/refs.c b/refs.c index d2aac24..c51fd45 100644 --- a/refs.c +++ b/refs.c @@ -518,6 +518,8 @@ const char *resolve_ref(const char *ref, unsigned char *sha1, int reading, int * /* Follow "normalized" - ie "refs/.." symlinks by hand */ if (S_ISLNK(st.st_mode)) { len = readlink(path, buffer, sizeof(buffer)-1); + if (len < 0) + return NULL; if (len >= 5 && !memcmp("refs/", buffer, 5)) { buffer[len] = 0; strcpy(ref_buffer, buffer); -- 1.7.6.8.gd2879