From: Nguyễn Thái Ngọc Duy Date: Mon, 15 Aug 2011 02:41:23 GMT Subject: [PATCH 2/2] diffcore-pickaxe: terminate grepping as soon as it hits Message-ID: <1313376083-24713-2-git-send-email-pclouds@gmail.com> In-Reply-To: <1313376083-24713-1-git-send-email-pclouds@gmail.com> Signed-off-by: Nguyễn Thái Ngọc Duy --- diffcore-pickaxe.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/diffcore-pickaxe.c b/diffcore-pickaxe.c index 12811b9..e028dd5 100644 --- a/diffcore-pickaxe.c +++ b/diffcore-pickaxe.c @@ -21,11 +21,7 @@ static int diffgrep_consume(void *priv, char *line, unsigned long len) if (line[0] != '+' && line[0] != '-') return 0; if (data->hit) - /* - * NEEDSWORK: we should have a way to terminate the - * caller early. - */ - return 0; + return -1; /* Yuck -- line ought to be "const char *"! */ hold = line[len]; line[len] = '\0'; -- 1.7.4.74.g639db