From: Ramkumar Ramachandra Date: Wed, 06 Jul 2011 07:54:17 GMT Subject: [PATCH 03/14] revert: Don't check lone argument in get_encoding Message-ID: <1309938868-2028-4-git-send-email-artagnon@gmail.com> In-Reply-To: <1309938868-2028-1-git-send-email-artagnon@gmail.com> The get_encoding function has only one callsite, and its caller makes sure that a NULL argument isn't passed. Don't unnecessarily double check the same argument in get_encoding. Suggested-by: Jonathan Nieder Suggested-by: Junio C Hamano Signed-off-by: Ramkumar Ramachandra --- builtin/revert.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/builtin/revert.c b/builtin/revert.c index 19d604c..a6b51b1 100644 --- a/builtin/revert.c +++ b/builtin/revert.c @@ -167,9 +167,6 @@ static char *get_encoding(const char *message) { const char *p = message, *eol; - if (!p) - die (_("Could not read commit message of %s"), - sha1_to_hex(commit->object.sha1)); while (*p && *p != '\n') { for (eol = p + 1; *eol && *eol != '\n'; eol++) ; /* do nothing */ -- 1.7.5.GIT