From: Erik Faye-Lund Date: Fri, 27 May 2011 16:00:40 GMT Subject: [PATCH 3/3] verify_path: consider dos drive prefix Message-ID: <1306512040-1468-4-git-send-email-kusmabite@gmail.com> In-Reply-To: <1306512040-1468-1-git-send-email-kusmabite@gmail.com> If someone manage to create a repo with a 'C:' entry in the root-tree, files can be written outside of the working-dir. This opens up a can-of-worms of exploits. Fix it by explicitly checking for a dos drive prefix when verifying a paht. While we're at it, make sure that paths beginning with '\' is considered absolute as well. Noticed-by: Theo Niessink Signed-off-by: Erik Faye-Lund --- read-cache.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/read-cache.c b/read-cache.c index f38471c..68faa51 100644 --- a/read-cache.c +++ b/read-cache.c @@ -753,11 +753,14 @@ int verify_path(const char *path) { char c; + if (has_dos_drive_prefix(path)) + return 0; + goto inside; for (;;) { if (!c) return 1; - if (c == '/') { + if (is_dir_sep(c)) { inside: c = *path++; switch (c) { -- 1.7.5.3.3.g435ff