From: Carlos Martín Nieto <cmn@elego.de>
Date: Tue, 15 Mar 2011 12:40:31 GMT
Subject: Re: [PATCH 1/3] make_absolute_path: Don't try to copy a string to itself
Message-ID: <1300192832.19100.35.camel@bee.lab.cmartin.tk>
In-Reply-To: <1300190396.19100.31.camel@bee.lab.cmartin.tk>

On mar, 2011-03-15 at 12:59 +0100, Carlos Martín Nieto wrote:
> On lun, 2011-03-14 at 15:58 -0700, Junio C Hamano wrote:
> > Carlos Martín Nieto <cmn@elego.de> writes:
[...]
> > 
> > >  There is however the extra functionality the function offers, namely
> > > resolving links. It might be good to split it into two functions so each
> > > caller can specify what it wants.
> > 
> > Probably.
> 
>  With the changes mentioned earlier, if you want an absolute pathname,
> you'd call absolute_path/make_nonrelative_path and if you want to make
> sure you have the real path of the target file, you'd use real_path just
> as you'd use realpath on a sane system, with

 ... a comment on the functions and maybe some documentation in
Documentation/techncal, as it doesn't seem to exist yet.

   cmn