From: Drew Northup <drew.northup@maine.edu>
Date: Mon, 20 Dec 2010 12:04:42 GMT
Subject: Re: [PATCH 2/3] gitweb: decorate a bit more remotes
Message-ID: <1292846682.19322.4.camel@drew-northup.unet.maine.edu>
In-Reply-To: <m3tyjglxi0.fsf@localhost.localdomain>


On Thu, 2010-12-16 at 14:23 -0800, Jakub Narebski wrote:
> Sylvain Rabot <sylvain@abstraction.fr> writes:
> 
> > Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
> > ---
> >  gitweb/gitweb.perl |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> > index db18d06..9398475 100755
> > --- a/gitweb/gitweb.perl
> > +++ b/gitweb/gitweb.perl
> > @@ -5127,13 +5127,13 @@ sub git_remote_block {
> >  
> >  	if (defined $fetch) {
> >  		if ($fetch eq $push) {
> > -			$urls_table .= format_repo_url("URL", $fetch);
> > +			$urls_table .= format_repo_url("<strong>URL:</strong>", $fetch);
> 
> I would really prefer to use CSS for that...

Agreed; <span class="repo_url">URL:</span> is far more appropriate in my
opinion.

-- 
-Drew Northup N1XIM
   AKA RvnPhnx on OPN
________________________________________________
"As opposed to vegetable or mineral error?"
-John Pescatore, SANS NewsBites Vol. 12 Num. 59