From: Erik Faye-Lund Date: Tue, 23 Nov 2010 17:30:40 GMT Subject: [RFC PATCH 2/6] msvc: opendir: allocate enough memory Message-ID: <1290533444-3404-3-git-send-email-kusmabite@gmail.com> In-Reply-To: <1290533444-3404-1-git-send-email-kusmabite@gmail.com> The defintion of DIR expects the allocating function to extend dd_name by over-allocating. This is not currently done in our implementation of opendir. Fix this. Signed-off-by: Erik Faye-Lund --- compat/msvc.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/compat/msvc.c b/compat/msvc.c index db3df51..205304e 100644 --- a/compat/msvc.c +++ b/compat/msvc.c @@ -5,12 +5,11 @@ DIR *opendir(const char *name) { - int len; + int len = strlen(p->dd_name); DIR *p; - p = xmalloc(sizeof(DIR)); - memset(p, 0, sizeof(DIR)); - strncpy(p->dd_name, name, PATH_MAX); - len = strlen(p->dd_name); + p = xmalloc(sizeof(DIR) + len + 2); + memset(p, 0, sizeof(DIR) + len + 2); + strcpy(p->dd_name, name); p->dd_name[len] = '/'; p->dd_name[len+1] = '*'; -- 1.7.3.2.493.ge4bf7