From: SZEDER Gábor Date: Sun, 10 Oct 2010 21:48:58 GMT Subject: [PATCH 3/3] bisect: check for mandatory argument of 'bisect replay' Message-ID: <1286747338-8521-3-git-send-email-szeder@ira.uka.de> In-Reply-To: <1286747338-8521-1-git-send-email-szeder@ira.uka.de> 'git bisect replay' has a mandatory logfile argument, but the current implementation doesn't check whether the user has specified one. When the user omits the logfile argument, this leads to the following unhelpful error message: cannot read for replaying So, check for the mandatory argument first, and provide a more meaningful error message when it is omitted. Signed-off-by: SZEDER Gábor --- git-bisect.sh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/git-bisect.sh b/git-bisect.sh index 68fcff6..c21e33c 100755 --- a/git-bisect.sh +++ b/git-bisect.sh @@ -343,6 +343,7 @@ bisect_clean_state() { } bisect_replay () { + test "$#" -eq 1 || die "No logfile given" test -r "$1" || die "cannot read $1 for replaying" bisect_reset while read git bisect command rev -- 1.7.3.1.148.g2fffa