From: Ævar Arnfjörð Bjarmason Date: Thu, 30 Sep 2010 13:43:02 GMT Subject: [PATCH 09/16] send-email: sanitize_address use $foo, not "$foo" Message-ID: <1285854189-10240-10-git-send-email-avarab@gmail.com> In-Reply-To: <1285854189-10240-1-git-send-email-avarab@gmail.com> There's no reason to explicitly stringify a variable in Perl unless it's an overloaded object and you want to call overload::StrVal, otherwise it's just creating a new scalar redundantly. Signed-off-by: Ævar Arnfjörð Bjarmason --- git-send-email.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index 1218bbe..1bf090a 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -864,7 +864,7 @@ sub sanitize_address { my ($recipient_name, $recipient_addr) = ($recipient =~ /^(.*?)\s*(<.*)/); if (not $recipient_name) { - return "$recipient"; + return $recipient; } # if recipient_name is already quoted, do nothing -- 1.7.3.159.g610493