From: Ævar Arnfjörð Bjarmason Date: Wed, 11 Aug 2010 19:04:06 GMT Subject: [PATCH v2 3/7] t/t7005-editor: change from skip_all=* to prereq skip Message-ID: <1281553450-26467-4-git-send-email-avarab@gmail.com> In-Reply-To: <7vd3tpxao1.fsf@alter.siamese.dyndns.org> Change this test to skip test with test prerequisites, and to do setup work in tests. This improves the skipped statistics on platforms where the test isn't run. Signed-off-by: Ævar Arnfjörð Bjarmason --- t/t7005-editor.sh | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/t/t7005-editor.sh b/t/t7005-editor.sh index 26ddf9d..1b530b5 100755 --- a/t/t7005-editor.sh +++ b/t/t7005-editor.sh @@ -111,13 +111,13 @@ do ' done -if ! echo 'echo space > "$1"' > "e space.sh" +if echo 'echo space > "$1"' > "e space.sh" then - skip_all="Skipping; FS does not support spaces in filenames" - test_done + # FS supports spaces in filenames + test_set_prereq SPACES_IN_FILENAMES fi -test_expect_success 'editor with a space' ' +test_expect_success SPACES_IN_FILENAMES 'editor with a space' ' chmod a+x "e space.sh" && GIT_EDITOR="./e\ space.sh" git commit --amend && @@ -126,7 +126,7 @@ test_expect_success 'editor with a space' ' ' unset GIT_EDITOR -test_expect_success 'core.editor with a space' ' +test_expect_success SPACES_IN_FILENAMES 'core.editor with a space' ' git config core.editor \"./e\ space.sh\" && git commit --amend && -- 1.7.2.1.295.gdf931