From: Will Palmer Date: Tue, 27 Jul 2010 20:18:56 GMT Subject: Re: [PATCH 2/3] checkout, commit: remove confusing assignments to rev.abbrev Message-ID: <1280261936.4462.6.camel@walleee> In-Reply-To: <20100727183706.GD5578@burratino> On Tue, 2010-07-27 at 13:37 -0500, Jonathan Nieder wrote: ... > v1.7.1.1~17^2~3 (2010-05-03) taught the log --format=%h machinery > to respect --abbrev instead of always abbreviating ... ... I've been seeing this phrasing throughout this discussion, and at first I thought it was merely a poor choice of words, but now I feel I must ensure it's clear: the purpose of the patch was to respect --abbrev instead of always abbreviating to a minimum of 7 characters. /Not/ to respect abbrev "instead of always abbreviating". Perhaps armed with that phrasing, a more general solution, such as equating "0" with "DEFAULT_ABBREV" rather than "no abbrev", could be applied? -- -- Will