From: Matthieu Moy Date: Mon, 26 Jul 2010 18:14:36 GMT Subject: [RFC PATCH 0/2] Allow detached forms (--option arg) for git log options. Message-ID: <1280168078-31147-1-git-send-email-Matthieu.Moy@imag.fr> Hi, This has been bothering me for a while: many commands accept detached form (like "git commit -m message" instead of "git commit -mmessage"), but others don't, in particular, git log options like git log -S git log --grep= do not accept spaces. This small patch serie is a very early RFC: it implements the feature for just two options. There are at least 4 ways towards a real implementations: 1) nobody except me likes the feature, drop the RFC. 2) Implement the same for other options. That's very repetitive (for each option, there are two ifs: a prefixcmp and a strcmp), I don't like it much. 3) Write a function or macro that accepts both variants, and use it everywhere. 4) use parse-option for "git log" options and then get the feature for free. Hence my question: is there any reason why "git log" hasn't been migrated to parse-option? Or is it only that nobody did it yet? What do you think? Thanks, Matthieu Moy (2): Allow "git log --grep foo" as synonym for "git log --grep=foo". Allow "git log -S string" as synonym for "git log -Sstring". diff.c | 5 +++++ revision.c | 4 ++++ 2 files changed, 9 insertions(+), 0 deletions(-) -- 1.7.2.23.g58c3b.dirty