From: SZEDER Gábor Date: Thu, 01 Jul 2010 11:07:45 GMT Subject: [PATCH 1/2] mingw: utime() handles NULL times parameter Message-ID: <1277982466-29601-1-git-send-email-szeder@ira.uka.de> In-Reply-To: <4C2C69AF.4010303@viscovery.net> POSIX sayeth: "If times is a null pointer, the access and modification times of the file shall be set to the current time." Let's do so. Signed-off-by: SZEDER Gábor --- On Thu, Jul 01, 2010 at 12:10:55PM +0200, Johannes Sixt wrote: > Mental note: update mingw_utime to accept NULL for the second parameter... Here it is, but I don't have mingw, so it's completely untested. compat/mingw.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index 9a8e336..a54db74 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -304,8 +304,14 @@ int mingw_utime (const char *file_name, const struct utimbuf *times) goto revert_attrs; } - time_t_to_filetime(times->modtime, &mft); - time_t_to_filetime(times->actime, &aft); + if (times) { + time_t_to_filetime(times->modtime, &mft); + time_t_to_filetime(times->actime, &aft); + } else { + GetSystemTimeAsFileTime(&mft); + aft->dwLowDateTime = mft->dwLowDateTime; + aft->dwHighDateTime = mft->dwHighDateTime; + } if (!SetFileTime((HANDLE)_get_osfhandle(fh), NULL, &aft, &mft)) { errno = EINVAL; rc = -1; -- 1.7.2.rc0.54.g4d821