From: Tay Ray Chuan Date: Tue, 11 May 2010 17:33:18 GMT Subject: [RFC PATCH] GIT-VERSION-GEN: restrict tags used Message-ID: <1273599198-1008-1-git-send-email-rctay89@gmail.com> Restrict the tags used to generate the version string to those that begin with "v", since git's tags for git-core (ie. excluding git-gui) are all of the form "vX.Y...". This is to avoid using private tags by the user in a clone of the git code repository, which may break certain machinery (eg. Makefile). Signed-off-by: Tay Ray Chuan --- Ran into this after tagging a topic branch and running make. Although a "v.*" match does not guarantee the non-usage of private tags, I feel it's an acceptable level of accuracy. After this patch, perhaps we could advertise somewhere to git hackers that tags beginning with "v" should be avoided. GIT-VERSION-GEN | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN index 59219bd..28b4d56 100755 --- a/GIT-VERSION-GEN +++ b/GIT-VERSION-GEN @@ -12,7 +12,7 @@ if test -f version then VN=$(cat version) || VN="$DEF_VER" elif test -d .git -o -f .git && - VN=$(git describe --abbrev=4 HEAD 2>/dev/null) && + VN=$(git describe --match "v*" --abbrev=4 HEAD 2>/dev/null) && case "$VN" in *$LF*) (exit 1) ;; v[0-9]*) -- 1.7.1.189.g07419