From: Tay Ray Chuan Date: Mon, 10 May 2010 17:17:49 GMT Subject: [PATCH 5/8] fmt-merge-msg: minor refactor of fmt_merge_msg() Message-ID: <1273511872-4924-6-git-send-email-rctay89@gmail.com> In-Reply-To: <1273511872-4924-1-git-send-email-rctay89@gmail.com> Shift implementation into a private function, do_fmt_merge_msg(). This allows for further changes to the implementation, without affecting the interface. Signed-off-by: Tay Ray Chuan --- builtin/fmt-merge-msg.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/builtin/fmt-merge-msg.c b/builtin/fmt-merge-msg.c index 379a031..a2bccd6 100644 --- a/builtin/fmt-merge-msg.c +++ b/builtin/fmt-merge-msg.c @@ -202,7 +202,8 @@ static void shortlog(const char *name, unsigned char *sha1, string_list_clear(&subjects, 0); } -int fmt_merge_msg(int merge_summary, struct strbuf *in, struct strbuf *out) { +static int do_fmt_merge_msg(int merge_summary, struct strbuf *in, + struct strbuf *out) { int limit = 20, i = 0, pos = 0; char *sep = ""; unsigned char head_sha1[20]; @@ -296,6 +297,10 @@ int fmt_merge_msg(int merge_summary, struct strbuf *in, struct strbuf *out) { return 0; } +int fmt_merge_msg(int merge_summary, struct strbuf *in, struct strbuf *out) { + return do_fmt_merge_msg(merge_summary, in, out); +} + int cmd_fmt_merge_msg(int argc, const char **argv, const char *prefix) { const char *inpath = NULL; -- 1.7.1.189.g07419