From: Will Palmer <wmpalmer@gmail.com>
Date: Sun, 02 May 2010 09:01:50 GMT
Subject: Re: [PATCH v3 4/5] pretty: add infrastructure to allow format aliases
Message-ID: <1272790910.4258.16.camel@walleee>
In-Reply-To: <7vhbmryp10.fsf@alter.siamese.dyndns.org>

On Sat, 2010-05-01 at 20:13 -0700, Junio C Hamano wrote:
> I however wonder if we would want to be more helpful to the users to
> diagnose this error by saying something here with error(), instead of just
> letting the caller say "invalid --pretty format: %s".

I suppose there's not really any sane reason why we wouldn't be able to
die then and there. If we pass the original name into the recursive
function, then the message could be:

"invalid --pretty format: %s references an alias which points to itself"

sound like okay wording?

-- 
-- Will