From: Will Palmer <wmpalmer@gmail.com>
Date: Sun, 02 May 2010 07:52:51 GMT
Subject: Re: [PATCH v3 2/5] pretty: make %H/%h/etc respect --abbrev[-commit]
Message-ID: <1272786771.4194.13.camel@walleee>
In-Reply-To: <7v39yazx4i.fsf@alter.siamese.dyndns.org>

On Sat, 2010-05-01 at 22:33 -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
> 
> > On Sat, May 01, 2010 at 08:13:00PM -0700, Junio C Hamano wrote:
> >

Sounds like this one remains controversial. I'll pull the format changes
out of the next pretty-alias series, and submit them as separate patches
later on. I still think the documentation implies that %H should be
abbreviated when --abbrev-commit is passed, but for now I'm going to
focus on cleaning up the pretty.alias code.
The eventual solution, I suspect, will involve a more-generic syntax as
was brought up in the previous discussion. Something like
%(abbrev-commit?%H), which would also be able to play with something
like [but, for obvious reasons, not exactly] %(is-merge?Merge: %p %p)

The %?C syntax seems to be generating less comment this time, and is the
one that I would find the most important to extending the usefulness of
format-aliases (ie: so that I can view a custom log with color in a
terminal, then output it to a text file and have it "do the right
thing"). Still, it would be lonely without %H/%h, so I'll stick it in
its own patch as well (once I fix it up a bit more, as mentioned in the
other thread).

-- 
-- Will