From: Matt McCutchen Date: Tue, 06 Apr 2010 03:14:20 GMT Subject: [PATCH] Makefile: move -Wall from CFLAGS to BASIC_CFLAGS Message-ID: <1270523660.3648.7.camel@mattlaptop2.local> -Wall cleanliness is an intended property of the codebase, so -Wall should be on by default even if the user's CFLAGS doesn't include it (e.g., the AC_PROG_CC configure test won't include it). --- Thoughts? Is there a problem with -Wall being GNU-specific? Makefile | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 7c616f8..88f9b47 100644 --- a/Makefile +++ b/Makefile @@ -241,7 +241,7 @@ endif # CFLAGS and LDFLAGS are for the users to override from the command line. -CFLAGS = -g -O2 -Wall +CFLAGS = -g -O2 LDFLAGS = ALL_CFLAGS = $(CFLAGS) ALL_LDFLAGS = $(LDFLAGS) @@ -308,7 +308,7 @@ SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__ # Those must not be GNU-specific; they are shared with perl/ which may # be built by a different compiler. (Note that this is an artifact now # but it still might be nice to keep that distinction.) -BASIC_CFLAGS = -I. +BASIC_CFLAGS = -Wall -I. BASIC_LDFLAGS = # Guard against environment variables -- 1.7.0.2.288.gb0894e