From: Erik Faye-Lund Date: Sat, 20 Mar 2010 18:55:29 GMT Subject: [PATCH v2 3/3] find_unique_abbrev: early out without a memcpy Message-ID: <1269111329-5896-4-git-send-email-kusmabite@gmail.com> In-Reply-To: <1269111329-5896-1-git-send-email-kusmabite@gmail.com> Signed-off-by: Erik Faye-Lund --- sha1_name.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sha1_name.c b/sha1_name.c index bf92417..2b1be58 100644 --- a/sha1_name.c +++ b/sha1_name.c @@ -196,10 +196,10 @@ const char *find_unique_abbrev(const unsigned char *sha1, int len) int status, exists; static char hex[41]; + if (len == 40 || !len) + return sha1_to_hex(sha1); exists = has_sha1_file(sha1); memcpy(hex, sha1_to_hex(sha1), 40); - if (len == 40 || !len) - return hex; while (len < 40) { unsigned char sha1_ret[20]; status = get_short_sha1(hex, len, sha1_ret, 1); -- 1.7.0.2.456.g64f24