From: Sam Vilain Date: Sat, 19 Dec 2009 16:37:38 GMT Subject: Re: [PATCH 2/5] git-svn: memoize conversion of SVN merge ticket info to git commit ranges Message-ID: <1261240658.20752.5.camel@denix> In-Reply-To: <1261240435-8948-3-git-send-email-sam@vilain.net> On Sun, 2009-12-20 at 05:33 +1300, Sam Vilain wrote: > Each time the svn mergeinfo ticket changes, we look it up in the rev_map; > when there are a lot of merged branches, this will result in many repeated > lookups of the same information for subsequent commits. Arrange the slow > part of the function so that it may be memoized, and memoize it. The more > expensive revision walking operation can be memoized separately. Sorry, that text was an old revision. Read as: Each time the svn mergeinfo ticket changes, we look it up in the rev_map; when there are a lot of merged branches, this will result in many repeated lookups of the same information for subsequent commits. Arrange that part of the function so that it may be memoized, and memoize it. Sam