From: Stephen Boyd Date: Tue, 08 Dec 2009 08:45:19 GMT Subject: Re: [PATCH v4 2/6] reset: use "unpack_trees()" directly instead of "git read-tree" Message-ID: <1260261919.1554.11.camel@swboyd-laptop> In-Reply-To: <20091208075616.4475.46720.chriscool@tuxfamily.org> On Tue, 2009-12-08 at 08:56 +0100, Christian Couder wrote: > +static int parse_and_init_tree_desc(const unsigned char *sha1, > + struct tree_desc *desc) > +{ > + struct tree *tree = parse_tree_indirect(sha1); > + if (!tree) > + return 1; > + init_tree_desc(desc, tree->buffer, tree->size); > + return 0; > +} > + > Is there a reason why you use this function instead of fill_tree_descriptor()?