From: Stephen Boyd <bebarino@gmail.com>
Date: Sun, 08 Nov 2009 23:11:06 GMT
Subject: Re: [PATCH 4/4] format-patch: Add "--no-stat" as a synonym for "-p"
Message-ID: <1257721866.1734.47.camel@swboyd-laptop>
In-Reply-To: <4AF544DF.6070404@gmail.com>

On Sat, 2009-11-07 at 10:58 +0100, Björn Gustavsson wrote:
> diff --git a/builtin-log.c b/builtin-log.c
> index 9df8dac..968a038 100644
> --- a/builtin-log.c
> +++ b/builtin-log.c
> @@ -925,7 +925,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
>  			"show patch format instead of default (patch + stat)"),
>  		OPT_BOOLEAN(0, "ignore-if-in-upstream", &ignore_if_in_upstream,
>  			    "don't include a patch matching a commit upstream"),
> -		OPT_BOOLEAN('p', NULL, &use_patch_format,
> +		OPT_BOOLEAN('p', "no-stat", &use_patch_format,
>  			"show patch format instead of default (patch + stat)"),
>  		OPT_GROUP("Messaging"),
>  		{ OPTION_CALLBACK, 0, "add-header", NULL, "header",


I think this needs to have the OPT_NO_NEG flag so users can't say
--no-no-stat.