From: Ben Walton Date: Thu, 29 Oct 2009 16:42:43 GMT Subject: [PATCH 0/2] Default Pager and Editor at build-time Message-ID: <1256834565-19443-1-git-send-email-bwalton@artsci.utoronto.ca> In-Reply-To: <20091029073224.GA15403@progeny.tock> The two patches look ok to me (not withstanding the comments already made about the test and possible future changes required). I did make a few small tweaks to use | instead of / as the sed substitution separator (since we're presumably working with full paths). The substitution was also extended into the .sh scripts (git-am, explicitly). Jonathan Nieder (1): Provide a build time default-editor setting Junio C Hamano (1): Provide a build time default-pager setting Makefile | 19 +++++++++++++++++++ editor.c | 2 +- git-add--interactive.perl | 3 ++- git-am.sh | 2 +- git-sh-setup.sh | 6 ++++-- git-svn.perl | 8 +++++--- pager.c | 2 +- t/Makefile | 2 ++ t/t7005-editor.sh | 29 ++++++++++++++++++++++------- 9 files changed, 57 insertions(+), 16 deletions(-)