From: Alex Vandiver <alex@chmrr.net>
Date: Fri, 24 Jul 2009 22:26:55 GMT
Subject: Re: [PATCH 2/2] After renaming a section, print any trailing variable definitions
Message-ID: <1248474081-sup-2762@utwig>
In-Reply-To: <20090725071105.6117@nanako3.lavabit.com>

At Fri Jul 24 18:11:05 -0400 2009, Nanako Shiraishi wrote:
> Quoting Alex Vandiver <alex@chmrr.net>
> > diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
> > index 43ea283..8c43dcd 100755
> > --- a/t/t1300-repo-config.sh
> > +++ b/t/t1300-repo-config.sh
> > @@ -460,6 +460,28 @@ EOF
> >  test_expect_success "rename succeeded" "test_cmp expect .git/config"
> >  
> >  cat >> .git/config << EOF
> > +[branch "vier"] z = 1
> > +EOF
> 
> Isn't this a syntax error?

Nope -- at least, not according to both the code, and the tests
(search or noNewline in t/t1300-repo-config.sh).

Though I also note that the documentation disagrees with the code in
the following case:

    Each variable must belong to some section, which means that there
    must be a section header before the first setting of a variable.

  $ cat >bogus
  foo = 42

  $ git config --file bogus --list
  foo=42

  $ git config --file bogus --get foo
  42

 - Alex
-- 
Networking -- only one letter away from not working