From: Paolo Bonzini Date: Sun, 28 Jun 2009 20:07:44 GMT Subject: [PATCH] git mailinfo strips important context from patch subjects Message-ID: <1246219664-11000-1-git-send-email-bonzini@gnu.org> In-Reply-To: <20090628193858.GA29467@codelibre.net> > Would it be possible to change the git-mailinfo logic to use a less > greedy pattern match? Like this? (I also simplified the first part of the if condition since I was at it). Anyone, feel free to resubmit it as a proper patch. Almost-Signed-off-by: Paolo Bonzini --- builtin-mailinfo.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/builtin-mailinfo.c b/builtin-mailinfo.c index 92637ac..d340ae6 100644 --- a/builtin-mailinfo.c +++ b/builtin-mailinfo.c @@ -237,7 +237,8 @@ static void cleanup_subject(struct strbuf *subject) case '[': if ((pos = strchr(subject->buf, ']'))) { remove = pos - subject->buf; - if (remove <= (subject->len - remove) * 2) { + if (remove <= subject->len * 2 / 3 + && memmem(subject->buf, remove, 'PATCH', 5)) { strbuf_remove(subject, 0, remove + 1); continue; } -- 1.6.0.3