From: Shawn O. Pearce Date: Mon, 04 May 2009 23:30:45 GMT Subject: [JGIT PATCH 4/7] Fix FindBugs load known null value Message-ID: <1241479848-20687-4-git-send-email-spearce@spearce.org> In-Reply-To: <1241479848-20687-3-git-send-email-spearce@spearce.org> We know its null, so use the null constant instead of the null variable here. Either way is pretty clear to the reader, but this form makes FindBugs be quiet. Signed-off-by: Shawn O. Pearce --- .../src/org/spearce/jgit/lib/ObjectDirectory.java | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectDirectory.java b/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectDirectory.java index bcbdbb0..d3c43da 100644 --- a/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectDirectory.java +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectDirectory.java @@ -314,9 +314,8 @@ private static boolean inList(final PackFile[] list, final PackFile pack) { private PackFile[] packs() { PackFile[] r = packList.get(); - if (r == null) { - r = scanPacks(r); - } + if (r == null) + r = scanPacks(null); return r; } -- 1.6.3.rc4.206.g03e16