From: Jeff Hostetler <git@jeffhostetler.com>
Date: Tue, 05 Dec 2017 15:45:28 GMT
Subject: Re: [PATCH v5 10/10] gc: do not repack promisor packfiles
Message-ID: <12409f04-5dd3-a823-6193-e17e9157ae16@jeffhostetler.com>
In-Reply-To: <CAP8UFD10YsCQtiFtLtzQ-PKsY93QaDC4zsO+k1tfauBs8ntt1w@mail.gmail.com>



On 12/2/2017 12:39 PM, Christian Couder wrote:
> On Tue, Nov 21, 2017 at 10:07 PM, Jeff Hostetler <git@jeffhostetler.com> wrote:
>> From: Jonathan Tan <jonathantanmy@google.com>
> 
>>   pack_as_from_promisor () {
>>          HASH=$(git -C repo pack-objects .git/objects/pack/pack) &&
>>          >repo/.git/objects/pack/pack-$HASH.promisor
>> +       echo $HASH
>>   }
> 
> Now the exit code of the above function will always be the exit code
> of "echo $HASH".
> It seems to me that it would be better to add "&&" at the end of the
> line above the "echo $HASH".
> 

Fixed. Thanks.
Jeff