From: Ben Walton Date: Mon, 23 Mar 2009 12:57:27 GMT Subject: Re: [PATCH] documentation: Makefile accounts for SHELL_PATH setting Message-ID: <1237812904-sup-3864@ntdws12.chass.utoronto.ca> In-Reply-To: <20090323065710.GA7048@coredump.intra.peff.net> Excerpts from Jeff King's message of Mon Mar 23 02:57:10 -0400 2009: > Nit: I have lots of systems where sh is not bash, and they work fine. It > is really about "where sh is not horribly broken". There aren't (AFAIK) > and should not be any bash-isms in these scripts. That's a fair point. I've been lugging this around for a bit in the build tree I use, so I don't recall specifically what was breaking. The sh in question is the one found in solaris 8. When I get a few mintues, I'll build without the patch to see what the problem was... > The patch itself looks fine; thanks for addressing my concerns. Thanks for the helpful feedback! :) -Ben -- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302 GPG Key Id: 8E89F6D2; Key Server: pgp.mit.edu Contact me to arrange for a CAcert assurance meeting.