From: Jeff King Date: Sat, 07 Mar 2009 17:14:05 GMT Subject: [PATCH 2/3] config: set help text for --bool-or-int Message-ID: <1236446046-18319-3-git-send-email-peff@peff.net> In-Reply-To: <1236446046-18319-1-git-send-email-peff@peff.net> The conversion to parse_opt left this as NULL; on glibc systems, the usage message prints --bool-or-int (null) and on other ones, segfaults. Signed-off-by: Jeff King --- I found this by running t1300 on a non-glibc system. I guess printing (null) is friendlier for real code, but for the test suite, it would be much more convenient to have it segfault to detect the bug. This is not the first such error we've had that I've caught in the same way. builtin-config.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin-config.c b/builtin-config.c index b11a096..1a3baa1 100644 --- a/builtin-config.c +++ b/builtin-config.c @@ -68,7 +68,7 @@ static struct option builtin_config_options[] = { OPT_GROUP("Type"), OPT_BIT(0, "bool", &types, "value is \"true\" or \"false\"", TYPE_BOOL), OPT_BIT(0, "int", &types, "value is decimal number", TYPE_INT), - OPT_BIT(0, "bool-or-int", &types, NULL, TYPE_BOOL_OR_INT), + OPT_BIT(0, "bool-or-int", &types, "value is --bool or --int", TYPE_BOOL_OR_INT), OPT_GROUP("Other"), OPT_BOOLEAN('z', "null", &end_null, "terminate values with NUL byte"), OPT_END(), -- 1.6.2.195.g44251.dirty