From: Keith Cascio Date: Fri, 13 Feb 2009 17:33:34 GMT Subject: [PATCH] Remove redundant bit clears from diff_setup() Message-ID: <1234546414-4416-1-git-send-email-keith@cs.ucla.edu> All bits already clear after memset(0). --- diff.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/diff.c b/diff.c index be3859e..006aa01 100644 --- a/diff.c +++ b/diff.c @@ -2319,29 +2319,26 @@ static void run_checkdiff(struct diff_filepair *p, struct diff_options *o) void diff_setup(struct diff_options *options) { memset(options, 0, sizeof(*options)); options->file = stdout; options->line_termination = '\n'; options->break_opt = -1; options->rename_limit = -1; options->dirstat_percent = 3; - DIFF_OPT_CLR(options, DIRSTAT_CUMULATIVE); options->context = 3; options->change = diff_change; options->add_remove = diff_addremove; if (diff_use_color_default > 0) DIFF_OPT_SET(options, COLOR_DIFF); - else - DIFF_OPT_CLR(options, COLOR_DIFF); options->detect_rename = diff_detect_rename_default; if (!diff_mnemonic_prefix) { options->a_prefix = "a/"; options->b_prefix = "b/"; } } int diff_setup_done(struct diff_options *options) { -- 1.6.1