From: Stefan Karpinski Date: Thu, 29 Jan 2009 21:35:14 GMT Subject: [PATCH] git-cvsserver: handle CVS 'noop' command. Message-ID: <1233264914-7798-1-git-send-email-stefan.karpinski@gmail.com> In-Reply-To: <1232144521-21947-1-git-send-email-stefan.karpinski@gmail.com> The implementation is trivial: ignore the 'noop' command if it is sent. This command is issued by some CVS clients, notably TortoiseCVS. Without this patch, TortoiseCVS will choke when git-cvsserver complains about the unsupported command. Signed-off-by: Stefan Karpinski --- Since this change has no negative impact, is too simple to be wrong, and improves interaction with some clients, it seem to me like a no-brainer to apply it. git-cvsserver.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-cvsserver.perl b/git-cvsserver.perl index fef7faf..c1e09ea 100755 --- a/git-cvsserver.perl +++ b/git-cvsserver.perl @@ -188,7 +188,7 @@ while () # use the $methods hash to call the appropriate sub for this command #$log->info("Method : $1"); &{$methods->{$1}}($1,$2); - } else { + } elsif ($1 ne 'noop') { # log fatal because we don't understand this function. If this happens # we're fairly screwed because we don't know if the client is expecting # a response. If it is, the client will hang, we'll hang, and the whole -- 1.6.0.3.3.g08dd8