From: Giuseppe Bilotta Date: Fri, 28 Nov 2008 20:39:51 GMT Subject: [PATCHv2 0/2] fixes to gitweb feature check code Message-ID: <1227904793-1821-1-git-send-email-giuseppe.bilotta@gmail.com> This is v2 of the gitweb feature check fix patch, which has now been split into into a code patch and cleanup patch. The first patch introduces git_get_feature() to clearly distinguish the feature retrieval from the boolean feature check (which is kept at git_check_feature()). The new function is used where appropriate. The second patch cleans up use of git_check_feature(): since the function now returns a boolean instead of an array, the often-used construct my ($somevar) = git_check_feature('somefeat'); although still valid, becomes a rather clumsy stylistic choice, as it introduces an unnecessary ambiguity. Make it clear that we're now dealing with scalars by using scalar assignment. Giuseppe Bilotta (2): gitweb: fixes to gitweb feature check code gitweb: clean up git_check_feature() calls gitweb/gitweb.perl | 52 +++++++++++++++++++++++++++++++++++----------------- 1 files changed, 35 insertions(+), 17 deletions(-)