From: crquan@gmail.com Date: Mon, 17 Nov 2008 11:15:51 GMT Subject: [PATCH 3/3] git-remote: simplifying get_one_entry Message-ID: <1226920551-28303-3-git-send-email-crquan@gmail.com> In-Reply-To: <1226920551-28303-2-git-send-email-crquan@gmail.com> From: Cheng Renquan The loop for remote->url_nr is really useless, set to the last one directly is better. Signed-off-by: Cheng Renquan --- builtin-remote.c | 10 +++------- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/builtin-remote.c b/builtin-remote.c index fff9920..59d69a5 100644 --- a/builtin-remote.c +++ b/builtin-remote.c @@ -839,13 +839,9 @@ static int get_one_entry(struct remote *remote, void *priv) { struct string_list *list = priv; - if (remote->url_nr > 0) { - int i; - - for (i = 0; i < remote->url_nr; i++) - string_list_append(remote->name, list)->util = (void *)remote->url[i]; - } else - string_list_append(remote->name, list)->util = NULL; + string_list_append(remote->name, list)->util = + remote->url_nr > 0 + ? (void *)remote->url[remote->url_nr-1] : NULL; return 0; } -- 1.6.0.2