From: Thomas Rast Date: Sun, 26 Oct 2008 19:37:06 GMT Subject: [PATCH v2] add -p: warn if only binary changes present Message-ID: <1225049826-14941-1-git-send-email-trast@student.ethz.ch> In-Reply-To: <20081026104006.GA18969@neumann> Current 'git add -p' will say "No changes." if there are no changes to text files, which can be confusing if there _are_ changes to binary files. Add some code to distinguish the two cases, and give a different message in the latter one. Signed-off-by: Thomas Rast --- SZEDER Gábor wrote: > What about > > Only binary files changed. > > or something of the sort? Yes, why not. git-add--interactive.perl | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/git-add--interactive.perl b/git-add--interactive.perl index da768ee..b0223c3 100755 --- a/git-add--interactive.perl +++ b/git-add--interactive.perl @@ -811,11 +811,16 @@ EOF } sub patch_update_cmd { - my @mods = grep { !($_->{BINARY}) } list_modified('file-only'); + my @all_mods = list_modified('file-only'); + my @mods = grep { !($_->{BINARY}) } @all_mods; my @them; if (!@mods) { - print STDERR "No changes.\n"; + if (@all_mods) { + print STDERR "Only binary files changed.\n"; + } else { + print STDERR "No changes.\n"; + } return 0; } if ($patch_mode) { -- tg: (759ad19..) t/add-p-binary-warn (depends on: origin/master)