From: Matt McCutchen <matt@mattmccutchen.net>
Date: Fri, 17 Oct 2008 04:33:14 GMT
Subject: Re: [PATCH try 2] t1301-shared-repo.sh: don't let a default ACL interfere with the test
Message-ID: <1224217994.10291.2.camel@mattlaptop2.local>
In-Reply-To: <7viqrrq1wz.fsf@gitster.siamese.dyndns.org>

On Thu, 2008-10-16 at 21:30 -0700, Junio C Hamano wrote:
> Matt McCutchen <matt@mattmccutchen.net> writes:
> > As I said in my other message, default ACLs do not break git, they only
> > break the way git is being tested in t1301-shared-repo.sh .  There is no
> > cause for concern.
> 
> Is it also true if the default is too tight?  Wouldn't that interfere with
> the attempt to loosen the permission bits by core.sharedrepository?

No.  adjust_shared_perm does an explicit chmod, which always sets
exactly the requested permissions.  A default ACL just replaces the
umask in the calculation of a file's *initial* permissions.

Matt