From: Marek Zawirski Date: Sun, 17 Aug 2008 20:44:03 GMT Subject: [EGIT PATCH 22/31] Set FileDialog selection appropriately in clone wizard Message-ID: <1219005852-21496-23-git-send-email-marek.zawirski@gmail.com> In-Reply-To: <1219005852-21496-22-git-send-email-marek.zawirski@gmail.com> Previous selection scheme was probably not correct, or at least not portable. It hasn't worked on GTK+ SWT implementation. New code still doesn't work on GTK+ SWT in Eclipse 3.3, but it works in Eclipse 3.4. FileDialog for GTK+ in 3.3 was probably buggy. I've created a bug at eclipse.org bugzilla for that (241824), but it won't be fixed for 3.3. Signed-off-by: Marek Zawirski --- .../ui/internal/clone/CloneDestinationPage.java | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/CloneDestinationPage.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/CloneDestinationPage.java index e1e9858..a445cf5 100644 --- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/CloneDestinationPage.java +++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/CloneDestinationPage.java @@ -128,9 +128,10 @@ class CloneDestinationPage extends WizardPage { d = new FileDialog(getShell(), SWT.APPLICATION_MODAL | SWT.SAVE); if (directoryText.getText().length() > 0) { - final File f = new File(directoryText.getText()); - d.setFilterPath(f.getAbsoluteFile().getAbsolutePath()); - d.setFileName(f.getName()); + final File file = new File(directoryText.getText()) + .getAbsoluteFile(); + d.setFilterPath(file.getParent()); + d.setFileName(file.getName()); } final String r = d.open(); if (r != null) -- 1.5.6.3