From: Dmitry Potapov Date: Sun, 03 Aug 2008 14:36:18 GMT Subject: [PATCH 1/5] correct argument checking test for git hash-object Message-ID: <1217774182-28566-1-git-send-email-dpotapov@gmail.com> In-Reply-To: <20080803055602.GN7008@dpotapov.dyndns.org> Because the file name given to stdin did not exist, git hash-object will fail to open it and exit with non-zero error code even if there is no check of arguments. Thus the test may pass despite the obvious error in argument checking. Signed-off-by: Dmitry Potapov --- t/t1007-hash-object.sh | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/t/t1007-hash-object.sh b/t/t1007-hash-object.sh index 1ec0535..6d505fa 100755 --- a/t/t1007-hash-object.sh +++ b/t/t1007-hash-object.sh @@ -49,16 +49,16 @@ setup_repo # Argument checking test_expect_success "multiple '--stdin's are rejected" ' - test_must_fail git hash-object --stdin --stdin < example + echo example | test_must_fail git hash-object --stdin --stdin ' test_expect_success "Can't use --stdin and --stdin-paths together" ' - test_must_fail git hash-object --stdin --stdin-paths && - test_must_fail git hash-object --stdin-paths --stdin + echo example | test_must_fail git hash-object --stdin --stdin-paths && + echo example | test_must_fail git hash-object --stdin-paths --stdin ' test_expect_success "Can't pass filenames as arguments with --stdin-paths" ' - test_must_fail git hash-object --stdin-paths hello < example + echo example | test_must_fail git hash-object --stdin-paths hello ' # Behavior -- 1.6.0.rc1.58.gacdf