From: Shawn O. Pearce Date: Fri, 25 Jul 2008 19:46:00 GMT Subject: [JGIT PATCH 2/9] Remove unnecessary duplicate if (help) test inside TextBuiltin Message-ID: <1217015167-4680-3-git-send-email-spearce@spearce.org> In-Reply-To: <1217015167-4680-2-git-send-email-spearce@spearce.org> This was caused by a copy-and-paste error as I borrowed the global argument handling code in Main to help start writing the command specific argument handling in TextBuiltin. Signed-off-by: Shawn O. Pearce --- .../src/org/spearce/jgit/pgm/TextBuiltin.java | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/TextBuiltin.java b/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/TextBuiltin.java index d02a0a2..e2eef84 100644 --- a/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/TextBuiltin.java +++ b/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/TextBuiltin.java @@ -145,11 +145,10 @@ public abstract class TextBuiltin { clp.printSingleLineUsage(System.err); System.err.println(); - if (help) { - System.err.println(); - clp.printUsage(System.err); - System.err.println(); - } + System.err.println(); + clp.printUsage(System.err); + System.err.println(); + System.exit(1); } -- 1.6.0.rc0.182.gb96c7