From: Johannes Sixt <johannes.sixt@telecom.at>
Date: Fri, 25 Jul 2008 08:32:02 GMT
Subject: Re: [PATCH 5/9 v2] Allow the built-in exec path to be relative to the command invocation path
Message-ID: <1216974722.48898f82e80d6@webmail.eunet.at>
In-Reply-To: <7v3aly5zz3.fsf@gitster.siamese.dyndns.org>

Zitat von Junio C Hamano <gitster@pobox.com>:
> However, I have to wonder if it is the right thing to do, like your patch
> does, for "git --exec-path" to return "../libexec/git-core/" in a relative
> form, without saying what it is relative to.  Shouldn't we be showing the
> full path after resolving that relative path to git executable?

Does it? "git --exec-path" calls git_exec_path(), and that now returns
system_path(GIT_EXEC_PATH), and that is an absolute path, although it's
not normalized.

Oh, I see: You tested it on Linux, right? This patch series does not work
correctly on Linux (Unix? bash?), as Dscho has pointed out, since argv[0]
does not have a directory part if "git" is in $PATH. In this case, system_path()
just returns its argument, which is the relative path. :-/

-- Hannes