From: Stephan Beyer Date: Thu, 12 Jun 2008 15:38:51 GMT Subject: [RFC/PATCH] git-commit: Change --reuse-message to --reuse-commit. Message-ID: <1213285131-32051-1-git-send-email-s-beyer@gmx.net> In-Reply-To: <20080612152928.GB6848@leksak.fem-net> The reason for the change is, that --reuse-message is misleading, because the long option name does not tell the user, that the authorship information is kept. --- Hi, I can imagine the negative feedback as * don't change long-time-used options * --reuse-commit, but --reedit-message? * ... But I want to give it a try ;-) 1. I think that the --reuse-message long option is not used by anyone, but you can quickly generate a counterexample :) Why not used? Because it was not documented in git-commit.txt until "Sun Jun 8 03:36:08 2008 +0200" (git show bc47c29). 2. Later we could add something like -M/--reuse-message that just reuses the message and not the authorship. See also the parent mail. http://article.gmane.org/gmane.comp.version-control.git/84760 Regards, Stephan Documentation/git-commit.txt | 2 +- builtin-commit.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt index 7e8b4ff..f713f40 100644 --- a/Documentation/git-commit.txt +++ b/Documentation/git-commit.txt @@ -59,7 +59,7 @@ OPTIONS told git about are not affected. -C :: ---reuse-message=:: +--reuse-commit=:: Take an existing commit object, and reuse the log message and the authorship information (including the timestamp) when creating the commit. diff --git a/builtin-commit.c b/builtin-commit.c index 90200ed..9c0b2da 100644 --- a/builtin-commit.c +++ b/builtin-commit.c @@ -90,7 +90,7 @@ static struct option builtin_commit_options[] = { OPT_STRING(0, "author", &force_author, "AUTHOR", "override author for commit"), OPT_CALLBACK('m', "message", &message, "MESSAGE", "specify commit message", opt_parse_m), OPT_STRING('c', "reedit-message", &edit_message, "COMMIT", "reuse and edit message from specified commit "), - OPT_STRING('C', "reuse-message", &use_message, "COMMIT", "reuse message from specified commit"), + OPT_STRING('C', "reuse-commit", &use_message, "COMMIT", "reuse message from specified commit"), OPT_BOOLEAN('s', "signoff", &signoff, "add Signed-off-by:"), OPT_STRING('t', "template", &template_file, "FILE", "use specified template file"), OPT_BOOLEAN('e', "edit", &edit_flag, "force edit of commit"), -- 1.5.5.3