From: Bryan Donlan Date: Sun, 04 May 2008 05:37:54 GMT Subject: [PATCH v3 04/10] test-lib.sh: Add a test_set_editor function to safely set $VISUAL Message-ID: <1209879480-16910-5-git-send-email-bdonlan@fushizen.net> In-Reply-To: <1209879480-16910-4-git-send-email-bdonlan@fushizen.net> In particular, this function correctly handles cases where the pwd contains spaces, quotes, and other troublesome metacharacters. Signed-off-by: Bryan Donlan --- t/test-lib.sh | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 7c2a8ba..d7ad13b 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -160,6 +160,22 @@ die () { trap 'die' exit +# The semantics of the editor variables are that of invoking +# sh -c "$EDITOR \"$@\"" files ... +# +# If our trash directory contains shell metacharacters, they will be +# interpreted if we just set $EDITOR directly, so do a little dance with +# environment variables to work around this. +# +# In particular, quoting isn't enough, as the path may contain the same quote +# that we're using. +test_set_editor () { + FAKE_EDITOR="$1" + export FAKE_EDITOR + VISUAL='"$FAKE_EDITOR"' + export VISUAL +} + test_tick () { if test -z "${test_tick+set}" then -- 1.5.5.1.128.g03a943